Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Static build for Python #13916

Merged
merged 7 commits into from
Jan 23, 2019
Merged

Static build for Python #13916

merged 7 commits into from
Jan 23, 2019

Conversation

lanking520
Copy link
Member

Description

Add Python static build in ci for verification
@szha @zachgk @marcoabreu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested a review from szha as a code owner January 17, 2019 05:18
marcoabreu
marcoabreu reviewed Jan 17, 2019
View reviewed changes
ci/jenkins/Jenkins_steps.groovy Outdated Show resolved Hide resolved
ci/docker/runtime_functions.sh Outdated Show resolved Hide resolved
@larroy
Copy link
Contributor

larroy commented Jan 17, 2019

I might have missed something, but why are we using ubuntu 14.04? Latest LTS is 18.04...

@stu1130
Copy link
Contributor

stu1130 commented Jan 17, 2019

@mxnet-label-bot add [pr-awaiting-review]
Great work! @lanking520

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 17, 2019
@lanking520
Copy link
Member Author

lanking520 commented Jan 17, 2019 •
edited
Loading

I might have missed something, but why are we using ubuntu 14.04? Latest LTS is 18.04...

@larroy For publishing, we are still using 14.04 due to the glibc versioning problem.

@lanking520
Copy link
Member Author

@szha @marcoabreu Please check again to see if this meet yours requirement

@marcoabreu marcoabreu merged commit f033aec into apache:master Jan 23, 2019
@marcoabreu
Copy link
Contributor

Looks great, thanks a ton!

jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
@lanking520
Static build for Python (apache#13916)
5dc749e 
* add python unit test

* address comments

* switch sanity test to Gluon module test

* We don't run tests (╯‵□′)╯︵┻━┻

* add variant in the environment variable

* add document improvement

* kill the conflict
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@lanking520 @stephenrawls
Static build for Python (apache#13916)
7cd390f 
* add python unit test

* address comments

* switch sanity test to Gluon module test

* We don't run tests (╯‵□′)╯︵┻━┻

* add variant in the environment variable

* add document improvement

* kill the conflict
@lanking520 lanking520 deleted the pip-test branch March 11, 2019 22:28
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@lanking520
Static build for Python (apache#13916)
a520456 
* add python unit test

* address comments

* switch sanity test to Gluon module test

* We don't run tests (╯‵□′)╯︵┻━┻

* add variant in the environment variable

* add document improvement

* kill the conflict
larroy
larroy reviewed Jan 31, 2020
View reviewed changes
ci/publish/python/build.sh

set -ex

source tools/staticbuild/build.sh $mxnet_variant pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why source?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu left review comments

@szha szha szha left review comments

@larroy larroy larroy left review comments

@zachgk zachgk zachgk approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lanking520 @larroy @stu1130 @marcoabreu @zachgk @szha